handle docker-compose v2, free up more space #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3809 +/- ##
==========================================
- Coverage 40.10% 37.65% -2.45%
==========================================
Files 155 202 +47
Lines 10044 12579 +2535
==========================================
+ Hits 4028 4737 +709
- Misses 5530 7256 +1726
- Partials 486 586 +100 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
hectorj2f
previously approved these changes
Aug 4, 2024
|
Tests still failing due to running out of space. |
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
|
@steiza my last commit seems to have fixed the docker-compose issue, let me see if i can finish the space issue |
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
haydentherapper
approved these changes
Aug 6, 2024
cmurphy
reviewed
Aug 6, 2024
Comment on lines
+67
to
+71
| if [ "$repo" == "fulcio" ]; then | ||
| yq -i e '.networks={"default":{ "name":"fulcio_default","external":true }}' docker-compose.yml | ||
| yq -i e '.services.fulcio-server.networks=["default"]' docker-compose.yml | ||
| tail docker-compose.yml | ||
| fi |
There was a problem hiding this comment.
FYI I think all this is unnecessary if you change line 27 to use label com.docker.compose.network=default
MMONSTER124
approved these changes
Aug 8, 2024
| echo "setting up OIDC provider" | ||
| pushd ./test/fakeoidc | ||
| oidcimg=$(ko build main.go --local) | ||
| docker network ls | grep fulcio_default || docker network create fulcio_default | ||
| docker network ls | grep fulcio_default || docker network create fulcio_default --label "com.docker.compose.network=fulcio_default" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new GH runner image only has
docker composeand our rules for deleting packages to make free space need updated.